From 06595f74b453cdb536d6c3161bac48ac355fb840 Mon Sep 17 00:00:00 2001 From: Eli Friedman Date: Thu, 27 Mar 2025 17:46:42 -0700 Subject: [PATCH] Revert "[MC] Explicitly mark MCSymbol for MO_ExternalSymbol" (#133291) Reverts llvm/llvm-project#108880 . The patch has no regression test, no description of why the fix is necessary, and the code is modifying MC datastructures in a way that's forbidden in the AsmPrinter. Fixes #132055. patch.cherry: true patch.metadata.original_sha: cd6e959102888279dc7e75a41ebd75a08ac3f7a5 patch.platforms: chromiumos patch.version_range.from: 550362 patch.version_range.until: 570122 --- llvm/lib/Target/X86/X86MCInstLower.cpp | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/llvm/lib/Target/X86/X86MCInstLower.cpp b/llvm/lib/Target/X86/X86MCInstLower.cpp index 0f8fbf5be1c9..4bb9a269f2d8 100644 --- a/llvm/lib/Target/X86/X86MCInstLower.cpp +++ b/llvm/lib/Target/X86/X86MCInstLower.cpp @@ -348,12 +348,8 @@ MCOperand X86MCInstLower::LowerMachineOperand(const MachineInstr *MI, return MCOperand::createImm(MO.getImm()); case MachineOperand::MO_MachineBasicBlock: case MachineOperand::MO_GlobalAddress: + case MachineOperand::MO_ExternalSymbol: return LowerSymbolOperand(MO, GetSymbolFromOperand(MO)); - case MachineOperand::MO_ExternalSymbol: { - MCSymbol *Sym = GetSymbolFromOperand(MO); - Sym->setExternal(true); - return LowerSymbolOperand(MO, Sym); - } case MachineOperand::MO_MCSymbol: return LowerSymbolOperand(MO, MO.getMCSymbol()); case MachineOperand::MO_JumpTableIndex: -- 2.49.0.504.g3bcea36a83-goog