/* * Copyright (C) 2024 The Android Open Source Project * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */ package com.android.car.hal.property; import static com.android.car.CarServiceUtils.toIntArray; import static com.google.common.truth.Truth.assertThat; import static com.google.common.truth.Truth.assertWithMessage; import static org.junit.Assert.assertThrows; import static org.mockito.Mockito.mock; import static org.mockito.Mockito.when; import android.car.Car; import android.car.VehiclePropertyIds; import android.car.feature.FakeFeatureFlagsImpl; import android.car.feature.Flags; import android.car.hardware.CarHvacFanDirection; import android.car.test.AbstractExpectableTestCase; import android.content.Context; import android.content.pm.PackageManager; import android.hardware.automotive.vehicle.VehicleGear; import android.hardware.automotive.vehicle.VehicleProperty; import android.hardware.automotive.vehicle.VehicleUnit; import android.hardware.automotive.vehicle.VehicleVendorPermission; import android.os.SystemClock; import android.platform.test.ravenwood.RavenwoodRule; import android.util.ArraySet; import android.util.SparseArray; import com.android.car.hal.HalPropValue; import com.android.car.hal.HalPropValueBuilder; import com.android.car.hal.property.PropertyHalServiceConfigs.CarSvcPropertyConfig; import com.android.car.hal.property.PropertyPermissionInfo.AllOfPermissions; import com.android.car.hal.property.PropertyPermissionInfo.AnyOfPermissions; import com.android.car.hal.property.PropertyPermissionInfo.PermissionCondition; import com.android.car.hal.property.PropertyPermissionInfo.PropertyPermissions; import com.android.car.hal.property.PropertyPermissionInfo.PropertyPermissionsBuilder; import com.android.car.hal.property.PropertyPermissionInfo.SinglePermission; import org.junit.Before; import org.junit.Rule; import org.junit.Test; import org.mockito.Mock; import org.mockito.MockitoAnnotations; import org.mockito.junit.MockitoJUnit; import org.mockito.junit.MockitoRule; import java.io.ByteArrayInputStream; import java.io.IOException; import java.io.InputStream; import java.nio.charset.StandardCharsets; import java.util.ArrayList; import java.util.List; import java.util.Set; public final class PropertyHalServiceConfigsUnitTest extends AbstractExpectableTestCase { private static final int VENDOR_PROPERTY_1 = 0x21e01111; private static final int VENDOR_PROPERTY_2 = 0x21e01112; private static final int VENDOR_PROPERTY_3 = 0x21e01113; private static final int VENDOR_PROPERTY_4 = 0x21e01114; private static final int[] VENDOR_PROPERTY_IDS = { VENDOR_PROPERTY_1, VENDOR_PROPERTY_2, VENDOR_PROPERTY_3, VENDOR_PROPERTY_4}; private static final int[] SYSTEM_PROPERTY_IDS = {VehiclePropertyIds.ENGINE_OIL_LEVEL, VehiclePropertyIds.CURRENT_GEAR, VehiclePropertyIds.NIGHT_MODE, VehiclePropertyIds.HVAC_FAN_SPEED, VehiclePropertyIds.DOOR_LOCK}; private static final int BACKPORTED_PROPERTY = 0x31e01111; @Rule public MockitoRule mMockitoRule = MockitoJUnit.rule(); @Rule public final RavenwoodRule mRavenwood = new RavenwoodRule.Builder().build(); @Mock private Context mContext; private PropertyHalServiceConfigs mPropertyHalServiceConfigs; private static final HalPropValueBuilder PROP_VALUE_BUILDER = new HalPropValueBuilder(/*isAidl=*/true); //payload test private static final HalPropValue GEAR_WITH_VALID_VALUE = PROP_VALUE_BUILDER.build(VehicleProperty.GEAR_SELECTION, /*areaId=*/0, /*timestamp=*/SystemClock.elapsedRealtimeNanos(), /*status=*/0, VehicleGear.GEAR_DRIVE); private static final HalPropValue GEAR_WITH_EXTRA_VALUE = PROP_VALUE_BUILDER.build(VehicleProperty.GEAR_SELECTION, /*areaId=*/0, /*timestamp=*/SystemClock.elapsedRealtimeNanos(), /*status=*/0, new int[]{VehicleGear.GEAR_DRIVE, VehicleGear.GEAR_1}); private static final HalPropValue GEAR_WITH_INVALID_VALUE = PROP_VALUE_BUILDER.build(VehicleProperty.GEAR_SELECTION, /*areaId=*/0, /*timestamp=*/SystemClock.elapsedRealtimeNanos(), /*status=*/0, VehicleUnit.KILOPASCAL); private static final HalPropValue GEAR_WITH_INVALID_TYPE_VALUE = PROP_VALUE_BUILDER.build(VehicleProperty.GEAR_SELECTION, /*areaId=*/0, /*timestamp=*/SystemClock.elapsedRealtimeNanos(), /*status=*/0, 1.0f); private static final HalPropValue HVAC_FAN_DIRECTIONS_VALID = PROP_VALUE_BUILDER.build(VehicleProperty.HVAC_FAN_DIRECTION, /*areaId=*/0, /*timestamp=*/SystemClock.elapsedRealtimeNanos(), /*status=*/0, CarHvacFanDirection.FACE | CarHvacFanDirection.FLOOR); private static final HalPropValue HVAC_FAN_DIRECTIONS_INVALID = PROP_VALUE_BUILDER.build(VehicleProperty.HVAC_FAN_DIRECTION, /*areaId=*/0, /*timestamp=*/SystemClock.elapsedRealtimeNanos(), /*status=*/0, CarHvacFanDirection.FACE | 0x100); private static final HalPropValue ULTRASONCIS_SENSOR_MEASURED_DISTANCE_WITH_ERROR_VALID = PROP_VALUE_BUILDER.build( /*prop=*/ VehiclePropertyIds.ULTRASONICS_SENSOR_MEASURED_DISTANCE, /*areaId=*/ 1, /*timestamp=*/ SystemClock.elapsedRealtimeNanos(), /*status=*/ 0, /*values=*/ new int[]{300, 10}); private static final HalPropValue ULTRASONCIS_SENSOR_MEASURED_DISTANCE_EMPTY_ARRAY_VALID = PROP_VALUE_BUILDER.build( /*prop=*/ VehiclePropertyIds.ULTRASONICS_SENSOR_MEASURED_DISTANCE, /*areaId=*/ 1, /*timestamp=*/ SystemClock.elapsedRealtimeNanos(), /*status=*/ 0, /*values=*/ new int[]{}); private FakeFeatureFlagsImpl mFakeFeatureFlags; @Before public void setUp() { MockitoAnnotations.initMocks(this); mFakeFeatureFlags = new FakeFeatureFlagsImpl(); mFakeFeatureFlags.setFlag(Flags.FLAG_VEHICLE_PROPERTY_REMOVE_SYSTEM_API_TAGS, true); mFakeFeatureFlags.setFlag(Flags.FLAG_VEHICLE_PROPERTY_25Q2_3P_PERMISSIONS, true); mFakeFeatureFlags.setFlag(Flags.FLAG_ANDROID_B_VEHICLE_PROPERTIES, true); mPropertyHalServiceConfigs = new PropertyHalServiceConfigs(mFakeFeatureFlags); when(mContext.checkCallingOrSelfPermission(Car.PERMISSION_CAR_ENGINE_DETAILED)) .thenReturn(PackageManager.PERMISSION_GRANTED); when(mContext.checkCallingOrSelfPermission(Car.PERMISSION_CONTROL_CAR_CLIMATE)) .thenReturn(PackageManager.PERMISSION_GRANTED); when(mContext.checkCallingOrSelfPermission(Car.PERMISSION_READ_WINDSHIELD_WIPERS)) .thenReturn(PackageManager.PERMISSION_DENIED); when(mContext.checkCallingOrSelfPermission(Car.PERMISSION_CONTROL_WINDSHIELD_WIPERS)) .thenReturn(PackageManager.PERMISSION_GRANTED); when(mContext.checkCallingOrSelfPermission(Car.PERMISSION_CONTROL_ADAS_STATES)) .thenReturn(PackageManager.PERMISSION_DENIED); when(mContext.checkCallingOrSelfPermission(Car.PERMISSION_READ_DISPLAY_UNITS)) .thenReturn(PackageManager.PERMISSION_DENIED); when(mContext.checkCallingOrSelfPermission(Car.PERMISSION_CONTROL_DISPLAY_UNITS)) .thenReturn(PackageManager.PERMISSION_GRANTED); when(mContext.checkCallingOrSelfPermission(Car.PERMISSION_VENDOR_EXTENSION)) .thenReturn(PackageManager.PERMISSION_GRANTED); } /** * Test {@link PropertyHalServiceConfigs#checkPayload(HalPropValue)} */ @Test public void testCheckPayload() { assertThat(mPropertyHalServiceConfigs.checkPayload(GEAR_WITH_VALID_VALUE)).isTrue(); assertThat(mPropertyHalServiceConfigs.checkPayload(GEAR_WITH_EXTRA_VALUE)).isFalse(); assertThat(mPropertyHalServiceConfigs.checkPayload(GEAR_WITH_INVALID_VALUE)).isFalse(); assertThat(mPropertyHalServiceConfigs.checkPayload(GEAR_WITH_INVALID_TYPE_VALUE)).isFalse(); assertThat(mPropertyHalServiceConfigs.checkPayload(HVAC_FAN_DIRECTIONS_VALID)).isTrue(); assertThat(mPropertyHalServiceConfigs.checkPayload(HVAC_FAN_DIRECTIONS_INVALID)).isFalse(); assertThat(mPropertyHalServiceConfigs .checkPayload(ULTRASONCIS_SENSOR_MEASURED_DISTANCE_WITH_ERROR_VALID)) .isTrue(); assertThat(mPropertyHalServiceConfigs .checkPayload(ULTRASONCIS_SENSOR_MEASURED_DISTANCE_EMPTY_ARRAY_VALID)) .isTrue(); } /** * Test {@link PropertyHalServiceConfigs#isReadable(Context, int)} * and {@link PropertyHalServiceConfigs#isWritable(Context, int)} for system properties */ @Test public void testIsReadableWritableForSystemProperty() { assertThat(mPropertyHalServiceConfigs .isReadable(mContext, VehiclePropertyIds.ENGINE_OIL_LEVEL)).isTrue(); assertThat(mPropertyHalServiceConfigs .isWritable(mContext, VehiclePropertyIds.ENGINE_OIL_LEVEL)).isFalse(); assertThat(mPropertyHalServiceConfigs .isReadable(mContext, VehiclePropertyIds.HVAC_FAN_SPEED)).isTrue(); assertThat(mPropertyHalServiceConfigs .isWritable(mContext, VehiclePropertyIds.HVAC_FAN_SPEED)).isTrue(); assertThat(mPropertyHalServiceConfigs .isReadable(mContext, VehiclePropertyIds.WINDSHIELD_WIPERS_SWITCH)).isTrue(); assertThat(mPropertyHalServiceConfigs .isWritable(mContext, VehiclePropertyIds.WINDSHIELD_WIPERS_SWITCH)).isTrue(); assertThat(mPropertyHalServiceConfigs .isReadable(mContext, VehiclePropertyIds.CRUISE_CONTROL_COMMAND)).isFalse(); assertThat(mPropertyHalServiceConfigs .isWritable(mContext, VehiclePropertyIds.CRUISE_CONTROL_COMMAND)).isFalse(); assertThat(mPropertyHalServiceConfigs .isReadable(mContext, VehiclePropertyIds.HVAC_TEMPERATURE_DISPLAY_UNITS)).isTrue(); assertThat(mPropertyHalServiceConfigs .isWritable(mContext, VehiclePropertyIds.HVAC_TEMPERATURE_DISPLAY_UNITS)).isTrue(); assertThat(mPropertyHalServiceConfigs .isReadable(mContext, VehiclePropertyIds.DISTANCE_DISPLAY_UNITS)).isFalse(); assertThat(mPropertyHalServiceConfigs .isWritable(mContext, VehiclePropertyIds.DISTANCE_DISPLAY_UNITS)).isTrue(); when(mContext.checkCallingOrSelfPermission(Car.PERMISSION_CONTROL_CAR_CLIMATE)) .thenReturn(PackageManager.PERMISSION_DENIED); when(mContext.checkCallingOrSelfPermission(Car.PERMISSION_VENDOR_EXTENSION)) .thenReturn(PackageManager.PERMISSION_DENIED); assertThat(mPropertyHalServiceConfigs .isReadable(mContext, VehiclePropertyIds.HVAC_TEMPERATURE_DISPLAY_UNITS)).isFalse(); assertThat(mPropertyHalServiceConfigs .isWritable(mContext, VehiclePropertyIds.HVAC_TEMPERATURE_DISPLAY_UNITS)).isFalse(); assertThat(mPropertyHalServiceConfigs .isReadable(mContext, VehiclePropertyIds.DISTANCE_DISPLAY_UNITS)).isFalse(); assertThat(mPropertyHalServiceConfigs .isWritable(mContext, VehiclePropertyIds.DISTANCE_DISPLAY_UNITS)).isFalse(); } /** * Test for READ-WRITE system properties that write permissions are present in read permissions. */ @Test public void testWritePermissionsExistInReadPermissionsForSystemProperty() { List allSystemHalPropIds = mPropertyHalServiceConfigs.getAllSystemHalPropIds(); for (int halPropId : allSystemHalPropIds) { PermissionCondition readPermission = mPropertyHalServiceConfigs.getReadPermission(halPropId); if (readPermission == null) { continue; } PermissionCondition writePermission = mPropertyHalServiceConfigs.getWritePermission(halPropId); // This skips the _DISPLAY_UNITS properties, which have multiple write permissions. if (!(writePermission instanceof SinglePermission)) { continue; } if (readPermission.equals(writePermission)) { continue; } assertWithMessage("Read permission " + readPermission + " of property " + VehiclePropertyIds.toString(halPropId) + " should be an instance of AnyOfPermissions if not equal to write permission") .that(readPermission instanceof AnyOfPermissions).isTrue(); assertWithMessage("Read permission " + readPermission + " of property " + VehiclePropertyIds.toString(halPropId) + " should be equal to or contain write permission " + writePermission) .that(((AnyOfPermissions) readPermission) .isMetIfGranted((SinglePermission) writePermission)).isTrue(); } } /** * Test {@link PropertyHalServiceConfigs#isReadable(Context, int)} * and {@link PropertyHalServiceConfigs#isWritable(Context, int)} for vendor properties */ @Test public void testIsReadableWritableForVendorProperty() { for (int vendorProp : VENDOR_PROPERTY_IDS) { assertThat(mPropertyHalServiceConfigs.isReadable(mContext, vendorProp)).isTrue(); assertThat(mPropertyHalServiceConfigs.isWritable(mContext, vendorProp)).isTrue(); } when(mContext.checkCallingOrSelfPermission(Car.PERMISSION_VENDOR_EXTENSION)) .thenReturn(PackageManager.PERMISSION_DENIED); for (int vendorProp : VENDOR_PROPERTY_IDS) { assertThat(mPropertyHalServiceConfigs.isReadable(mContext, vendorProp)).isFalse(); assertThat(mPropertyHalServiceConfigs.isWritable(mContext, vendorProp)).isFalse(); } } /** * Test {@link PropertyHalServiceConfigs#isSupportedProperty} */ @Test public void testIsSupportedProperty() { for (int vendorProp : VENDOR_PROPERTY_IDS) { expectWithMessage("vendor property: " + vendorProp + " is supported").that( mPropertyHalServiceConfigs.isSupportedProperty(vendorProp)).isTrue(); } for (int systemProp : SYSTEM_PROPERTY_IDS) { expectWithMessage("system property: " + VehiclePropertyIds.toString(systemProp) + " is supported").that( mPropertyHalServiceConfigs.isSupportedProperty(systemProp)).isTrue(); } int fakeSystemPropId = 0x1fffffff; expectWithMessage("fake system property: " + fakeSystemPropId + " is not supported").that( mPropertyHalServiceConfigs.isSupportedProperty(fakeSystemPropId)).isFalse(); int fakePropId = 0xffffffff; expectWithMessage("fake property: " + fakePropId + " is not supported").that( mPropertyHalServiceConfigs.isSupportedProperty(fakePropId)).isFalse(); expectWithMessage("backported property: " + BACKPORTED_PROPERTY + " is supported").that( mPropertyHalServiceConfigs.isSupportedProperty(BACKPORTED_PROPERTY)).isTrue(); } /** * Test {@link PropertyHalServiceConfigs#customizeVendorPermission(int[])} */ @Test public void testCustomizeVendorPermission() { List configArray = new ArrayList<>(); // set up read permission and write permission to VENDOR_PROPERTY_1 configArray.add(VENDOR_PROPERTY_1); configArray.add(VehicleVendorPermission.PERMISSION_DEFAULT); configArray.add(VehicleVendorPermission.PERMISSION_NOT_ACCESSIBLE); // set up read permission and write permission to VENDOR_PROPERTY_2 configArray.add(VENDOR_PROPERTY_2); configArray.add(VehicleVendorPermission.PERMISSION_GET_VENDOR_CATEGORY_ENGINE); configArray.add(VehicleVendorPermission.PERMISSION_SET_VENDOR_CATEGORY_ENGINE); // set up read permission and write permission to VENDOR_PROPERTY_3 configArray.add(VENDOR_PROPERTY_3); configArray.add(VehicleVendorPermission.PERMISSION_GET_VENDOR_CATEGORY_INFO); configArray.add(VehicleVendorPermission.PERMISSION_DEFAULT); // set up read permission and write permission to BACKPORTED_PROPERTY configArray.add(BACKPORTED_PROPERTY); configArray.add(VehicleVendorPermission.PERMISSION_GET_VENDOR_CATEGORY_INFO); configArray.add(VehicleVendorPermission.PERMISSION_DEFAULT); mPropertyHalServiceConfigs.customizeVendorPermission(toIntArray(configArray)); assertThat(mPropertyHalServiceConfigs.getReadPermission(VENDOR_PROPERTY_1) .toString()).isEqualTo(Car.PERMISSION_VENDOR_EXTENSION); assertThat(mPropertyHalServiceConfigs.getWritePermission(VENDOR_PROPERTY_1)).isNull(); assertThat(mPropertyHalServiceConfigs.getReadPermission(VENDOR_PROPERTY_2) .toString()).isEqualTo(android.car.hardware.property .VehicleVendorPermission.PERMISSION_GET_CAR_VENDOR_CATEGORY_ENGINE); assertThat(mPropertyHalServiceConfigs.getWritePermission(VENDOR_PROPERTY_2) .toString()).isEqualTo(android.car.hardware.property .VehicleVendorPermission.PERMISSION_SET_CAR_VENDOR_CATEGORY_ENGINE); assertThat(mPropertyHalServiceConfigs.getReadPermission(VENDOR_PROPERTY_3) .toString()).isEqualTo(android.car.hardware.property .VehicleVendorPermission.PERMISSION_GET_CAR_VENDOR_CATEGORY_INFO); assertThat(mPropertyHalServiceConfigs.getWritePermission(VENDOR_PROPERTY_3) .toString()).isEqualTo(Car.PERMISSION_VENDOR_EXTENSION); assertThat(mPropertyHalServiceConfigs.getReadPermission(VENDOR_PROPERTY_4) .toString()).isEqualTo(Car.PERMISSION_VENDOR_EXTENSION); assertThat(mPropertyHalServiceConfigs.getWritePermission(VENDOR_PROPERTY_4) .toString()).isEqualTo(Car.PERMISSION_VENDOR_EXTENSION); assertThat(mPropertyHalServiceConfigs.getReadPermission(BACKPORTED_PROPERTY) .toString()).isEqualTo(android.car.hardware.property .VehicleVendorPermission.PERMISSION_GET_CAR_VENDOR_CATEGORY_INFO); assertThat(mPropertyHalServiceConfigs.getWritePermission(BACKPORTED_PROPERTY) .toString()).isEqualTo(Car.PERMISSION_VENDOR_EXTENSION); when(mContext.checkCallingOrSelfPermission(Car.PERMISSION_VENDOR_EXTENSION)) .thenReturn(PackageManager.PERMISSION_GRANTED); when(mContext.checkCallingOrSelfPermission( android.car.hardware.property.VehicleVendorPermission .PERMISSION_GET_CAR_VENDOR_CATEGORY_ENGINE)) .thenReturn(PackageManager.PERMISSION_GRANTED); when(mContext.checkCallingOrSelfPermission( android.car.hardware.property.VehicleVendorPermission .PERMISSION_SET_CAR_VENDOR_CATEGORY_ENGINE)) .thenReturn(PackageManager.PERMISSION_GRANTED); when(mContext.checkCallingOrSelfPermission( android.car.hardware.property.VehicleVendorPermission .PERMISSION_GET_CAR_VENDOR_CATEGORY_INFO)) .thenReturn(PackageManager.PERMISSION_DENIED); assertThat(mPropertyHalServiceConfigs.isReadable(mContext, VENDOR_PROPERTY_1)).isTrue(); assertThat(mPropertyHalServiceConfigs.isWritable(mContext, VENDOR_PROPERTY_1)).isFalse(); assertThat(mPropertyHalServiceConfigs.isReadable(mContext, VENDOR_PROPERTY_2)).isTrue(); assertThat(mPropertyHalServiceConfigs.isWritable(mContext, VENDOR_PROPERTY_2)).isTrue(); assertThat(mPropertyHalServiceConfigs.isReadable(mContext, VENDOR_PROPERTY_3)).isFalse(); assertThat(mPropertyHalServiceConfigs.isWritable(mContext, VENDOR_PROPERTY_3)).isTrue(); assertThat(mPropertyHalServiceConfigs.isReadable(mContext, VENDOR_PROPERTY_4)).isTrue(); assertThat(mPropertyHalServiceConfigs.isWritable(mContext, VENDOR_PROPERTY_4)).isTrue(); assertThat(mPropertyHalServiceConfigs.isReadable(mContext, BACKPORTED_PROPERTY)).isFalse(); assertThat(mPropertyHalServiceConfigs.isWritable(mContext, BACKPORTED_PROPERTY)).isTrue(); } @Test public void testCustomizeVendorPermission_systemPropertyNotAllowed() { List configArray = new ArrayList<>(); configArray.add(VehiclePropertyIds.CURRENT_GEAR); configArray.add( VehicleVendorPermission.PERMISSION_GET_VENDOR_CATEGORY_ENGINE); configArray.add( VehicleVendorPermission.PERMISSION_SET_VENDOR_CATEGORY_ENGINE); assertThrows(IllegalArgumentException.class, () -> mPropertyHalServiceConfigs.customizeVendorPermission(toIntArray(configArray))); } @Test public void testCustomizeVendorPermission_overrideNotAllowed() { List configArray = new ArrayList<>(); configArray.add(VENDOR_PROPERTY_1); configArray.add(VehicleVendorPermission.PERMISSION_DEFAULT); configArray.add(VehicleVendorPermission.PERMISSION_NOT_ACCESSIBLE); // This must not take effect. configArray.add(VENDOR_PROPERTY_1); configArray.add(VehicleVendorPermission.PERMISSION_GET_VENDOR_CATEGORY_ENGINE); configArray.add(VehicleVendorPermission.PERMISSION_SET_VENDOR_CATEGORY_ENGINE); mPropertyHalServiceConfigs.customizeVendorPermission(toIntArray(configArray)); assertThat(mPropertyHalServiceConfigs.getReadPermission(VENDOR_PROPERTY_1) .toString()).isEqualTo(Car.PERMISSION_VENDOR_EXTENSION); assertThat(mPropertyHalServiceConfigs.getWritePermission(VENDOR_PROPERTY_1)).isNull(); } private InputStream strToInputStream(String str) { return new ByteArrayInputStream(str.getBytes(StandardCharsets.UTF_8)); } @Test public void testParseJsonConfig_validConfig() throws Exception { InputStream is = strToInputStream(""" { 'version': 1, 'properties': { 'PROP_NAME': { 'propertyName': 'PROP_NAME', 'propertyId': 1234, 'vhalPropertyId': 2345, 'description': 'DESCRIPTION', 'readPermission': { 'type': 'anyOf', 'value': [ { 'type': 'single', 'value': 'PERM1' }, { 'type': 'single', 'value': 'PERM2' } ] }, 'writePermission': { 'type': 'allOf', 'value': [ { 'type': 'single', 'value': 'PERM1' }, { 'type': 'single', 'value': 'PERM2' } ] }, 'dataEnums': [0, 1, 2] } } } """); int propertyId = 1234; int halPropId = 2345; String propertyName = "PROP_NAME"; String description = "DESCRIPTION"; var permissions = new PropertyPermissionsBuilder() .setReadPermission(new AnyOfPermissions( new SinglePermission("PERM1"), new SinglePermission("PERM2") )) .setWritePermission(new AllOfPermissions( new SinglePermission("PERM1"), new SinglePermission("PERM2") )) .build(); var dataEnums = new ArraySet<>(Set.of(0, 1, 2)); CarSvcPropertyConfig expectedConfig = new CarSvcPropertyConfig(propertyId, halPropId, propertyName, description, permissions, dataEnums, /* validBitFlag= */ null); SparseArray configs = mPropertyHalServiceConfigs.parseJsonConfig( is, /* path= */ "test", null); assertWithMessage("expect one config parsed").that(configs.size()).isEqualTo(1); CarSvcPropertyConfig config = configs.get(2345); assertThat(config).isNotNull(); assertThat(config).isEqualTo(expectedConfig); } @Test public void testParseJsonConfig_halPropIdDefaultEqualPropId() throws Exception { InputStream is = strToInputStream(""" { "version": 1, "properties": { "PROP_NAME": { "propertyName": "PROP_NAME", "propertyId": 1234, "description": "DESCRIPTION", "readPermission": { "type": "single", "value": "PERM1" } } } } """); int propertyId = 1234; int halPropId = 1234; String propertyName = "PROP_NAME"; String description = "DESCRIPTION"; PropertyPermissions permissions = new PropertyPermissionsBuilder() .setReadPermission(new SinglePermission("PERM1")) .build(); var expectedConfig = new CarSvcPropertyConfig(propertyId, halPropId, propertyName, description, permissions, /* dataEnums= */ null, /* validBitFlag= */ null); SparseArray configs = mPropertyHalServiceConfigs.parseJsonConfig( is, /* path= */ "test", null); CarSvcPropertyConfig config = configs.get(1234); assertThat(config).isNotNull(); assertThat(config).isEqualTo(expectedConfig); } @Test public void testParseJsonConfig_dataFlags() throws Exception { InputStream is = strToInputStream(""" { "version": 1, "properties": { "PROP_NAME": { "propertyName": "PROP_NAME", "propertyId": 1234, "description": "DESCRIPTION", "readPermission": { "type": "single", "value": "PERM1" }, "dataFlags": [1, 2, 4, 8] } } } """); int propertyId = 1234; int halPropId = 1234; String propertyName = "PROP_NAME"; String description = "DESCRIPTION"; PropertyPermissions permissions = new PropertyPermissionsBuilder() .setReadPermission(new SinglePermission("PERM1")) .build(); // Bit: 1111 int validBitFlag = 15; var expectedConfig = new CarSvcPropertyConfig(propertyId, halPropId, propertyName, description, permissions, /* dataEnums= */ null, validBitFlag); SparseArray configs = mPropertyHalServiceConfigs.parseJsonConfig( is, /* path= */ "test", null); CarSvcPropertyConfig config = configs.get(1234); assertThat(config).isNotNull(); assertThat(config).isEqualTo(expectedConfig); } @Test public void testParseJsonConfig_ignoreDeprecate() throws Exception { InputStream is = strToInputStream(""" { "version": 1, "properties": { "OLD_PROP": { "propertyName": "OLD_PROP", "propertyId": 12345, "deprecated": true }, "PROP_NAME": { "propertyName": "PROP_NAME", "propertyId": 1234, "vhalPropertyId": 2345, "description": "DESCRIPTION", "readPermission": { "type": "single", "value": "PERM1" } } } } """); SparseArray configs = mPropertyHalServiceConfigs.parseJsonConfig( is, /* path= */ "test", null); assertWithMessage("deprecated property must be ignored").that(configs.get(12345)).isNull(); assertWithMessage("must continue parsing non deprecated property").that(configs.get(2345)) .isNotNull(); } @Test public void testParseJsonConfig_cannotReadFromStream() throws Exception { InputStream is = mock(InputStream.class); when(is.readAllBytes()).thenThrow(new IOException()); assertThrows(IllegalArgumentException.class, () -> mPropertyHalServiceConfigs.parseJsonConfig(is, /* path= */ "test", null)); } @Test public void testParseJsonConfig_invalidJsonFormat() throws Exception { InputStream is = strToInputStream("{"); assertThrows(IllegalArgumentException.class, () -> mPropertyHalServiceConfigs.parseJsonConfig(is, /* path= */ "test", null)); } @Test public void testParseJsonConfig_missingPropertyIdField() throws Exception { InputStream is = strToInputStream(""" { "version": 1, "properties": { "PROP_NAME": { "propertyName": "PROP_NAME", "vhalPropertyId": 2345, "description": "DESCRIPTION", "readPermission": { "type": "single", "value": "PERM1" } } } } """); assertThrows(IllegalArgumentException.class, () -> mPropertyHalServiceConfigs.parseJsonConfig(is, /* path= */ "test", null)); } @Test public void testParseJsonConfig_noReadOrWritePermission() throws Exception { InputStream is = strToInputStream(""" { "version": 1, "properties": { "PROP_NAME": { "propertyName": "PROP_NAME", "propertyId": 1234, "description": "DESCRIPTION", "dataFlags": [1, 2, 4, 8] } } } """); assertThrows(IllegalArgumentException.class, () -> mPropertyHalServiceConfigs.parseJsonConfig(is, /* path= */ "test", null)); } @Test public void testParseJsonConfig_25q23pPermissionsFlagDisabledConfig() throws Exception { int propertyId = 1234; int halPropId = 1234; String propertyName = "PROP_NAME"; String description = "DESCRIPTION"; var permissions = new PropertyPermissionsBuilder() .setReadPermission(new SinglePermission("PERM1")) .build(); var dataEnums = new ArraySet<>(Set.of(0, 1, 2)); CarSvcPropertyConfig expectedConfig = new CarSvcPropertyConfig(propertyId, halPropId, propertyName, description, permissions, dataEnums, /* validBitFlag= */ null); InputStream releasedInputStream = strToInputStream(""" { "version": 1, "properties": { "PROP_NAME": { "propertyName": "PROP_NAME", "propertyId": 1234, "description": "DESCRIPTION", "readPermission": { "type": "single", "value": "PERM1" }, "dataEnums": [ 0, 1, 2 ] } } } """); InputStream generatedInputStream = strToInputStream(""" { "version": 1, "properties": { "PROP_NAME": { "propertyName": "PROP_NAME", "propertyId": 1234, "description": "DESCRIPTION", "readPermission": { "type": "anyOf", "value": [ { "type": "single", "value": "PERM1" }, { "type": "single", "value": "PERM2" } ] }, "dataEnums": [ 0, 1, 2 ], "featureFlag": "FLAG_VEHICLE_PROPERTY_25Q2_3P_PERMISSIONS" } } } """); mFakeFeatureFlags.setFlag(Flags.FLAG_VEHICLE_PROPERTY_25Q2_3P_PERMISSIONS, false); SparseArray releasedConfigs = mPropertyHalServiceConfigs.parseJsonConfig( releasedInputStream, /* path= */ "test", null); SparseArray generatedConfigs = mPropertyHalServiceConfigs.parseJsonConfig( generatedInputStream, /* path= */ "test", releasedConfigs); assertWithMessage("expect one config parsed").that(releasedConfigs.size()).isEqualTo(1); assertWithMessage("expect one config parsed").that(generatedConfigs.size()).isEqualTo(1); CarSvcPropertyConfig releasedConfig = releasedConfigs.get(propertyId); CarSvcPropertyConfig generatedConfig = generatedConfigs.get(propertyId); assertThat(releasedConfig).isNotNull(); assertThat(generatedConfig).isNotNull(); assertThat(releasedConfig).isEqualTo(expectedConfig); assertThat(generatedConfig).isEqualTo(expectedConfig); } @Test public void testParseJsonConfig_25q23pPermissionsFlagEnabledConfig() throws Exception { int propertyId = 1234; int halPropId = 1234; String propertyName = "PROP_NAME"; String description = "DESCRIPTION"; var permissions = new PropertyPermissionsBuilder() .setReadPermission(new AnyOfPermissions( new SinglePermission("PERM1"), new SinglePermission("PERM2") )) .build(); var dataEnums = new ArraySet<>(Set.of(0, 1, 2)); CarSvcPropertyConfig expectedConfig = new CarSvcPropertyConfig(propertyId, halPropId, propertyName, description, permissions, dataEnums, /* validBitFlag= */ null); InputStream releasedInputStream = strToInputStream(""" { "version": 1, "properties": { "PROP_NAME": { "propertyName": "PROP_NAME", "propertyId": 1234, "description": "DESCRIPTION", "readPermission": { "type": "single", "value": "PERM1" }, "dataEnums": [ 0, 1, 2 ] } } } """); InputStream generatedInputStream = strToInputStream(""" { "version": 1, "properties": { "PROP_NAME": { "propertyName": "PROP_NAME", "propertyId": 1234, "description": "DESCRIPTION", "readPermission": { "type": "anyOf", "value": [ { "type": "single", "value": "PERM1" }, { "type": "single", "value": "PERM2" } ] }, "dataEnums": [ 0, 1, 2 ], "featureFlag": "FLAG_VEHICLE_PROPERTY_25Q2_3P_PERMISSIONS" } } } """); mFakeFeatureFlags.setFlag(Flags.FLAG_VEHICLE_PROPERTY_25Q2_3P_PERMISSIONS, true); SparseArray releasedConfigs = mPropertyHalServiceConfigs.parseJsonConfig( releasedInputStream, /* path= */ "test", null); SparseArray generatedConfigs = mPropertyHalServiceConfigs.parseJsonConfig( generatedInputStream, /* path= */ "test", releasedConfigs); assertWithMessage("expect one config parsed").that(releasedConfigs.size()).isEqualTo(1); assertWithMessage("expect one config parsed").that(generatedConfigs.size()).isEqualTo(1); CarSvcPropertyConfig releasedConfig = releasedConfigs.get(propertyId); CarSvcPropertyConfig generatedConfig = generatedConfigs.get(propertyId); assertThat(releasedConfig).isNotNull(); assertThat(generatedConfig).isNotNull(); assertThat(generatedConfig).isEqualTo(expectedConfig); } @Test public void testManagerToHalPropId() { assertThat(mPropertyHalServiceConfigs.managerToHalPropId( VehiclePropertyIds.VEHICLE_SPEED_DISPLAY_UNITS)).isEqualTo( VehicleProperty.VEHICLE_SPEED_DISPLAY_UNITS); } @Test public void testHalToManagerPropId() { assertThat(mPropertyHalServiceConfigs.halToManagerPropId( VehicleProperty.VEHICLE_SPEED_DISPLAY_UNITS)).isEqualTo( VehiclePropertyIds.VEHICLE_SPEED_DISPLAY_UNITS); } @Test public void testVehiclePropertyRemoveSystemApiTagFlagEnabledNoOp() throws Exception { int previouslySystemApiProperty = VehiclePropertyIds.HEAD_UP_DISPLAY_ENABLED; mFakeFeatureFlags.setFlag(Flags.FLAG_VEHICLE_PROPERTY_REMOVE_SYSTEM_API_TAGS, true); mPropertyHalServiceConfigs = new PropertyHalServiceConfigs(mFakeFeatureFlags); assertThat(mPropertyHalServiceConfigs.getAllSystemHalPropIds()) .contains(previouslySystemApiProperty); assertThat(mPropertyHalServiceConfigs.isSupportedProperty(previouslySystemApiProperty)) .isTrue(); } @Test public void testVehiclePropertyRemoveSystemApiTagFlagDisabledNoOp() throws Exception { int previouslySystemApiProperty = VehiclePropertyIds.HEAD_UP_DISPLAY_ENABLED; mFakeFeatureFlags.setFlag(Flags.FLAG_VEHICLE_PROPERTY_REMOVE_SYSTEM_API_TAGS, false); mPropertyHalServiceConfigs = new PropertyHalServiceConfigs(mFakeFeatureFlags); assertThat(mPropertyHalServiceConfigs.getAllSystemHalPropIds()) .contains(previouslySystemApiProperty); assertThat(mPropertyHalServiceConfigs.isSupportedProperty(previouslySystemApiProperty)) .isTrue(); } @Test public void testVehicleProperty2025q23pPermissionFlagEnabledNoOp() throws Exception { // SEAT_OCCUPANCY is one of the 8 properties that have permission changes flagged by // FLAG_25Q2_3P_PERMISSIONS. int previouslySignaturePrivilegedProperty = VehiclePropertyIds.SEAT_OCCUPANCY; mFakeFeatureFlags.setFlag(Flags.FLAG_VEHICLE_PROPERTY_25Q2_3P_PERMISSIONS, true); mPropertyHalServiceConfigs = new PropertyHalServiceConfigs(mFakeFeatureFlags); assertThat(mPropertyHalServiceConfigs.getAllSystemHalPropIds()) .contains(previouslySignaturePrivilegedProperty); assertThat(mPropertyHalServiceConfigs .isSupportedProperty(previouslySignaturePrivilegedProperty)) .isTrue(); } @Test public void testVehicleProperty2025q23pPermissionFlagDisabledNoOp() throws Exception { // SEAT_OCCUPANCY is one of the 8 properties that have permission changes flagged by // FLAG_25Q2_3P_PERMISSIONS. int previouslySignaturePrivilegedProperty = VehiclePropertyIds.SEAT_OCCUPANCY; mFakeFeatureFlags.setFlag(Flags.FLAG_VEHICLE_PROPERTY_25Q2_3P_PERMISSIONS, false); mPropertyHalServiceConfigs = new PropertyHalServiceConfigs(mFakeFeatureFlags); assertThat(mPropertyHalServiceConfigs.getAllSystemHalPropIds()) .contains(previouslySignaturePrivilegedProperty); assertThat(mPropertyHalServiceConfigs .isSupportedProperty(previouslySignaturePrivilegedProperty)) .isTrue(); } @Test public void testBVehiclePropertiesFlagDisabled() throws Exception { int androidBProperty = VehiclePropertyIds.INFO_MODEL_TRIM; mFakeFeatureFlags.setFlag(Flags.FLAG_ANDROID_B_VEHICLE_PROPERTIES, false); mPropertyHalServiceConfigs = new PropertyHalServiceConfigs(mFakeFeatureFlags); assertThat(mPropertyHalServiceConfigs.getAllSystemHalPropIds()) .doesNotContain(androidBProperty); assertThat(mPropertyHalServiceConfigs.isSupportedProperty(androidBProperty)).isFalse(); } @Test public void test25q23pPermissionsFlagDisabled() throws Exception { int previouslySignaturePrivilegedProperty = VehiclePropertyIds.SEAT_OCCUPANCY; mFakeFeatureFlags.setFlag(Flags.FLAG_VEHICLE_PROPERTY_25Q2_3P_PERMISSIONS, false); mPropertyHalServiceConfigs = new PropertyHalServiceConfigs(mFakeFeatureFlags); assertThat(mPropertyHalServiceConfigs.getAllSystemHalPropIds()) .contains(previouslySignaturePrivilegedProperty); assertThat( mPropertyHalServiceConfigs .isSupportedProperty(previouslySignaturePrivilegedProperty)) .isTrue(); } @Test public void test25q23pPermissionsFlagEnabled() throws Exception { int previouslySignaturePrivilegedProperty = VehiclePropertyIds.SEAT_OCCUPANCY; mFakeFeatureFlags.setFlag(Flags.FLAG_VEHICLE_PROPERTY_25Q2_3P_PERMISSIONS, true); mPropertyHalServiceConfigs = new PropertyHalServiceConfigs(mFakeFeatureFlags); assertThat(mPropertyHalServiceConfigs.getAllSystemHalPropIds()) .contains(previouslySignaturePrivilegedProperty); assertThat( mPropertyHalServiceConfigs .isSupportedProperty(previouslySignaturePrivilegedProperty)) .isTrue(); } }